[riot-notifications] [RIOT-OS/RIOT] make: add LOG_LEVEL to overridable variables (#11592)

Martine Lenders notifications at github.com
Tue May 28 17:06:49 CEST 2019


miri64 requested changes on this pull request.



> @@ -141,9 +141,8 @@ ifeq ($(DEVELHELP),1)
   CFLAGS += -DDEVELHELP
 endif
 
-# If not already set in CFLAGS, set logging level by default to INFO, e.g. 3.
-LOG_LEVEL ?= 3
-ifeq (,$(filter -DLOG_LEVEL=%,$(CFLAGS)))
+# Override LOG_LEVEL if variable is set
+ifdef LOG_LEVEL

Now you don't check anymore if the CFLAGS are already setting `LOG_LEVEL`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11592#pullrequestreview-242734573
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190528/9e12e3e2/attachment.html>


More information about the notifications mailing list