[riot-notifications] [RIOT-OS/RIOT] gnrc_sixlowpan_frag: Initial import of a fragment size hint feature (#11061)

Cenk Gündoğan notifications at github.com
Tue May 28 19:14:44 CEST 2019


cgundogan commented on this pull request.



> @@ -94,6 +97,13 @@ typedef struct {
     uint16_t tag;           /**< Tag used for the fragment */
     uint16_t offset;        /**< Offset of the Nth fragment from the beginning of the
                              *   payload datagram */
+#ifdef MODULE_GNRC_SIXLOWPAN_FRAG_HINT
+    /**
+     * @brief   Hint for the size (smaller than link-layer PDU) of the
+     *          *first fragment*

Why **first** fragment? The code seems to indicate something else (for all fragments?). Also, other parts of the documentation also refer to more fragments than just the first.

> @@ -0,0 +1,59 @@
+/*
+ * Copyright (C) 2019 Freie Universität Berlin
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @defgroup    net_gnrc_sixlowpan_frag_hint    Fragment size hint
+ * @ingroup     net_gnrc_sixlowpan_frag
+ * @brief       Provides a hint for smaller fragment sizes than the link-layer
+ *              PDU for the *first fragment*.

As above, why **first**?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11061#pullrequestreview-242807762
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190528/cc29e84e/attachment.html>


More information about the notifications mailing list