[riot-notifications] [RIOT-OS/RIOT] boards/frdm-kw41z-k64f: add riotboot (#11562)

Francisco notifications at github.com
Wed May 29 10:00:38 CEST 2019


> The OUTPUT_FORMAT/OUTPUT_ARCH may not be needed as they are set in cortexm_base.ld.

I'm not sure about what the precedence between the definition of these and sections or memory declaration must be. I found in some doc (not arm specific ld) `the name of the output section is section. section must meet the constraints of your output format.` Also they are not using the same `OUTPUT_FORMAT`:

kinetis:

```
OUTPUT_FORMAT ("elf32-littlearm", "elf32-bigarm", "elf32-littlearm")
OUTPUT_ARCH(arm)
```

cortex common:
```
OUTPUT_FORMAT("elf32-littlearm", "elf32-littlearm", "elf32-littlearm")
OUTPUT_ARCH(arm)
```

> I think that somehow all the LINKFLAGS with defsym in cpu/kinetis/Makefile.include can be removed as already defined by cpu/cortexm_common/Makefile.include (_ram_base_addr is unused from a git grep search, did not check history yet)

Checked and removed it

> To put the riotboot features, it may be a good idea to check that the same issue as #11274 is not present.

Do you have frdm-k22f? I think this PR should work with frdm-k22f by just adding `FEATURES_PROVIDED+=riotboot`.

> It could be the right time to put the _rom_offset/_fw_rom_length calculation in its own file to not 

Another ld script file?


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11562#issuecomment-496829192
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190529/aabe7c09/attachment.html>


More information about the notifications mailing list