[riot-notifications] [RIOT-OS/RIOT] pkg/semtech-loramac: provide basic persistence for session keys and devaddr (#11552)

Francisco notifications at github.com
Wed May 29 09:21:26 CEST 2019


fjmolinas requested changes on this pull request.

I like and agree with these changes, In general it looks good. Some minor comments code wise. 

Also, I tested on b-l072z-lrwan1. Some comments regarding functionality issues:

- when joining the join status isn't directly saved to eeprom, but only upon an eeprom_save. I think this should be done automatically just as for the uplink counter.

- After joining and saving the join status, I rebooted the node and tried to transmit right away. The node hanged for about 4min before getting a "Message sent with success"

> @@ -406,7 +444,7 @@ void semtech_loramac_erase_config(void)
                   LORAMAC_DEVEUI_LEN + LORAMAC_APPEUI_LEN +
                   LORAMAC_APPKEY_LEN + LORAMAC_APPSKEY_LEN +
                   LORAMAC_NWKSKEY_LEN + LORAMAC_DEVADDR_LEN +
-                  uplink_counter_len);
+                  uplink_counter_len + 1);

Why is this +1, is it the joined bit? Can you use a define?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11552#pullrequestreview-243075880
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190529/98a9ab44/attachment-0001.html>


More information about the notifications mailing list