[riot-notifications] [RIOT-OS/RIOT] tools/jlink: Fix do_term (#11604)
notifications at github.com
Wed May 29 09:43:13 CEST 2019
### Contribution description
As described in #11343 currently running `make term` does not work on boards that use J-Link Segger RTT, pyterm cannot connect to the Segger RTT server and it fails. By adding a delay after the server is launched pyterm is able to connect to the specified port.
This PR adds that delay, and also modifies the `do_term` function so it exits when pressing "Ctrl+C".
### Testing procedure
Try to run `make term` on some board that uses Segger RTT for the terminal (e.g. Ruuvitag, Thingy:52, Hamilton) on master: it should fail. After applying this PR the terminal should work.
e.g.: `BOARD=ruuvitag make flash term`
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* tools/jlink: Wait for server before pyterm
* tools/jlink: Exit terminal on Ctrl+C
-- File Changes --
M dist/tools/jlink/jlink.sh (14)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications