[riot-notifications] [RIOT-OS/RIOT] pkg/libb2: fix build on esp8266 (#12135)

Gunar Schorcht notifications at github.com
Sun Sep 1 16:30:55 CEST 2019


gschorcht commented on this pull request.



> @@ -2,6 +2,7 @@ MODULE = libb2
 
 # Compiling for native triggers this warning
 CFLAGS += -Wno-unused-function
+CFLAGS += -DSUFFIX=

We should find another solution. Ignoring `pkg/libb2/config.h` completely, could also produce problems in future when this file is changed and contains definitions that are required.

What if we would rename `pkg/libb2/config.h/config.h` as you did and provide a patch file to include the renamed file. Providing a patch file to change something in original source code is the standard approach in RIOT packages, see section [Creating a patch with git](http://doc.riot-os.org/group__pkg.html). This would be the solution I would prefer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12135#discussion_r319762436
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190901/2c892b28/attachment.htm>


More information about the notifications mailing list