[riot-notifications] [RIOT-OS/RIOT] tests/driver_bmp180: cleanup application (#12140)

benpicco notifications at github.com
Mon Sep 2 11:26:54 CEST 2019


benpicco commented on this pull request.



>                 "Pressure [hPa]: %lu.%d\n"
                "Pressure at see level [hPa]: %lu.%d\n"
               "Altitude [m]: %i\n"
                "\n+-------------------------------------+\n",
+               (negative ? '-' : ' '),
                (int)(temperature / 10), (int)(temperature % 10),


```suggestion
                (int)(temperature / 10), abs(temperature % 10),
```

No need to introduce an extra variable here (and manually add the sign) 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12140#pullrequestreview-282491764
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190902/697dd48d/attachment.htm>


More information about the notifications mailing list