[riot-notifications] [RIOT-OS/RIOT] tests, examples/usb: PID, VID warning only when building. (#12146)

Juan I Carrano notifications at github.com
Mon Sep 2 12:25:10 CEST 2019


### Contribution description

The warning issued when the PID and VID are set to the default values should not be printed on `make clean` and other targets, only with `make all` and it should be a proper target.

### Testing procedure

Run:

```
$ make -C tests/usbus_cdc_ecm clean
$ make -C examples/usbus_minimal/ clean
```

With this pr: no warnings. With master: red warning messages.

Run:
```
$ make -C tests/usbus_cdc_ecm
$ make -C examples/usbus_minimal
```

Warnings are still there.

Run:

```
$ USB_VID=1 USB_PID=1 make -C tests/usbus_cdc_ecm
$ USB_VID=1 USB_PID=1 make -C examples/usbus_minimal
```

Warnings go away.

### Issues/PRs references

To do: replace shell echos with proper $(warning ..) calls once #12126 is in.

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/12146

-- Commit Summary --

  * tests,examples/usb: PID, VID warning only when building.

-- File Changes --

    M examples/usbus_minimal/Makefile (18)
    M tests/usbus_cdc_ecm/Makefile (18)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/12146.patch
https://github.com/RIOT-OS/RIOT/pull/12146.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12146
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190902/daa3375f/attachment.htm>


More information about the notifications mailing list