[riot-notifications] [RIOT-OS/RIOT] pkg/oonf_api: Use MRI script to combine archives. (#12155)
Juan I Carrano
notifications at github.com
Mon Sep 2 16:53:16 CEST 2019
### Contribution description
The OONF package is combining multiple ".a" file into a single archive. The way it was being done involved creating and changing directories, unpacking the original archives and repacking them into a combined one.
Theis has a couple of issues:
- It is untidy and wasteful.
- It breaks when thin archives are enabled, as a thin archive cannot be unpacked.
This commit uses a MRI script to do the combining step. It works both with and without thin archives and is cleaner overall.
An issue that remains to be soved is that make is calling itself to create the archive, as the PARTIAL_ARCHIVES are not known before hand. This is hacky. It can be solved but it is a subject for another PR.
### Testing procedure
The OONF example should still compile.
### Issues/PRs references
needed for #10195 .
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* pkg/oonf_api: Use MRI script to combine archives.
-- File Changes --
M pkg/oonf_api/Makefile (26)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications