[riot-notifications] [RIOT-OS/RIOT] dist/tools/openocd: add OPENOCD_EXTRA_INIT_RESET use for nucleo-f091rc (#11976)
notifications at github.com
Mon Sep 2 21:05:09 CEST 2019
Is this not funny when you think about it?
A PR open for almost one month, no reviewer reviewing it.
Me, contributor, as I like this change, spent several hours in the manual, testing the implementation, doing local tests of openocd, challenging with the other boards that had similar fix, test my own PRs that addressed the same issue in the old way based on this change, rebase my PRs on it, give feedback on the implementation, the limitation, the documentation.
Then, as it is discovered today that it is needed for a board in the CI, it "would be nice to be in quickly", so gets merged based on maintainers testing only the fixed board, not the whole feature and concept, and on "I trust this contributor".
Not even taking the responsibility of the review, the required effort for doing it, or even acknowledging the previous feedback.
"I want it all, and I want it now"
If it was that urgent, adding at least a "thank you, you saved our ass" would have been welcomed.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications