[riot-notifications] [RIOT-OS/RIOT] dist/tools/openocd: add OPENOCD_EXTRA_INIT_RESET use for nucleo-f091rc (#11976)
notifications at github.com
Tue Sep 3 11:20:38 CEST 2019
> 3\. I looked over this PR and saw it adds only a few lines, also there was a discussion between you and @fjmolinas sorting things out and several tests showed positiv results. Hence, with +/- 600 open PRs, this looked like an easy one to get of the stack.
That is exactly why I complain about not getting an explicit review.
This is not a simple change! Francisco managed to be so right and precise with this fix.
Maybe it end up in only a few makefile/shell lines, but the important part is not the integration but the openocd part, what it solves, how, why it works, which impact it will have. What were we doing before and why were we not doing this?
What impact does it have on https://github.com/RIOT-OS/RIOT/pull/8976 and https://github.com/RIOT-OS/RIOT/pull/10479 ?
Does it deprecate the 5 other handling in RIOT ?
I personally rebased 3 of my PRs on this one, open one to use this and added a cleanup/bug fix.
> Btw. I don't remember ever getting a thank you for a PR I made; for reviews and testing -- yes, many times. Generally I don't deem it necessary, but appreciated it is.
It was not a thing when I started, but at least all the last ones with you have :) https://github.com/RIOT-OS/RIOT/pulls?q=is%3Apr+reviewed-by%3Asmlng+author%3Acladmi+is%3Amerged
> > A PR open for almost one month, no reviewer reviewing it.
> Well, I have to say that I was interested by this PR and with @fjmolinas we discussed it IRL as he mentioned at the beginning of the discussion. It's just that vacations came in between.
It was to put it in contrast with the really quick merge with no maintainer explicit review. I know you were both in vacation.
> But what I find funny with your comment, is that you (@cladmi) consider yourself as a simple contributor just because you decided (I still don't understand why honestly) to resign from the maintainer status. But we all know here that you were maintainer not so long ago and already did (a lot of) good reviews and merged quite some stuff. And that's why people trust a not so simple contributor like you.
Trust is unfortunately not a review. I do not trust what I do.
I trust that I do mistakes all the time and try to compensate by giving enough noise around so they can be found.
And yes, I am a contributor and should be considered as such.
As long as a review can be done without following https://github.com/RIOT-OS/RIOT/blob/master/MAINTAINING.md I am better as a contributor.
(btw, if I am in a state where a review is not necessary for my contributions, I have many PRs waiting :p)
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications