[riot-notifications] [RIOT-OS/RIOT] board/nucleo-l412kb (#12144)

benpicco notifications at github.com
Tue Sep 3 16:02:45 CEST 2019


benpicco commented on this pull request.



> @@ -288,8 +288,6 @@ typedef struct
 
 /**
   * @brief External Interrupt/Event Controller
-  *
-  * Note: IMR1, EMR1, ... were changed to IMR, EMR, ...

Please don't do this!
Change the code, not the vendor files. Things will break if a new version of the vendor file gets released or a new MCU version is added.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12144#pullrequestreview-283017356
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190903/353ba656/attachment-0001.htm>


More information about the notifications mailing list