[riot-notifications] [RIOT-OS/RIOT] shell_commands: gnrc_netif: add support for getting/setting PHY modes & options (#12171)

benpicco notifications at github.com
Thu Sep 5 03:19:10 CEST 2019


# Contribution description

I'm getting afraid that if #12128 gets too big, nobody will review it, so I factored out the part that makes changes to common code.

This patch adds support for setting PHY modes as specified in 802.15.4 as well as those added in IEEE 802.15.4g-2012.

If the driver implements support for it, this adds commands to configure

 - Chip/s & rate mode for O-QPSK
 - Modulation / Coding Scheme and Option for OFDM
 - Modulation Index, Modulation Order, Symbol Rate and Forward Error Correction for FSK

Modulation Index is represented as fractions on 64 to ease implementations.

Some options are also applicable for `at86rf2xx` and `mrf24j40` (probably others too, I just didn't look), they could also add more configurable for e.g. BPSK options.
I will add try to add implementations for some existing drivers to this PR.

### Testing procedure

```
ifconfig 7 set phy_mode FSK
ifconfig 7 set modulation_index 1/2
ifconfig 7 set symbol_rate 150
ifconfig 7 set forward_error_correction NRNSC
```

Should do nothing unless the driver supports it.

### Issues/PRs references
#12128 is the first driver to make use of this interface

In the future, those blocks should be guarded with `#ifdef`s that only enable them if a radio driver is selected that supports the corresponding option set, to avoid filling up all ROM with useless Strings.

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/12171

-- Commit Summary --

  * shell_commands: gnrc_netif: add support for getting/setting PHY modes

-- File Changes --

    M sys/include/net/ieee802154.h (34)
    M sys/include/net/netopt.h (45)
    M sys/shell/commands/sc_gnrc_netif.c (295)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/12171.patch
https://github.com/RIOT-OS/RIOT/pull/12171.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12171
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190904/10d74dcc/attachment-0001.htm>


More information about the notifications mailing list