[riot-notifications] [RIOT-OS/RIOT] random: add hwrng and puf_sram as FEATURES_OPTIONAL (#12166)

Gaëtan Harter notifications at github.com
Thu Sep 5 10:53:20 CEST 2019


What behavior is this supposed to give? I understand the description but do not get what behavior is wanted.

>From a reading review of the changes and the previous code only:

I think this changed the behavior in some cases.
Because if a board provides both `puf_sram` and `periph_hwrng` they will be both included.
Where before, if you defined `USEMODULE += puf_sram` in your application you would not have `periph_hwrng` (note that it is an **ifeq**`(,$(filter puf_sram,$(USEMODULE))` so gets inside when the module is not here to handle default behavior)

The previous behavior however had determinism issues though, as if `puf_sram` was added as a sub dependency after multiple iterations of the parsing, `periph_hwrng` would be already in features optional, but not if `puf_sram` was added as dependency in the application Makefile.

So needs some careful look of what is wanted.
And depending on this, how we can achieve it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12166#issuecomment-528267780
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190905/a19cefb1/attachment-0001.htm>


More information about the notifications mailing list