[riot-notifications] [RIOT-OS/RIOT] random: add hwrng and puf_sram as FEATURES_OPTIONAL (#12166)

Francisco notifications at github.com
Thu Sep 5 15:41:26 CEST 2019


> What behavior is this supposed to give? I understand the description but do not get what behavior is wanted.

You are right I didn't present enough of a description. I complemented the PR description accordingly.

> Because if a board provides both puf_sram and periph_hwrng they will be both included.
> Where before, if you defined USEMODULE += puf_sram in your application you would not have periph_hwrng (note that it is an ifeq(,$(filter puf_sram,$(USEMODULE)) so gets inside when the module is not here to handle default behavior)

You are right. I changed this because even though the code gets built it wont end up in the compiled fw, since the initialization for `random_init` prioritizes it over `puf_sram`.

I could revert that specific change and remove `periph_hwrng` from `USEMODULE` if `puf_sram` and `random` are present in `USE_MODULE`, would that be ok? Would you suggest a cleaner way?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12166#issuecomment-528370388
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190905/0d0c852e/attachment-0001.htm>


More information about the notifications mailing list