[riot-notifications] [RIOT-OS/RIOT] cpu/esp8266: complete reimplementation based on ESP8266 RTOS SDK (#11108)
notifications at github.com
Thu Sep 5 17:08:30 CEST 2019
> sure, just give us another ping when you made the rebase and you think this is ready to be reviewed and tested. I will find time for that ...
Ping @smlng :wink: After 2 weeks of hard work I'm really proud to inform that I have finished the rebase/rework of this PR with a lot of improvements and a lot of extensions.
In fact, the reimplementation has been finished. It is working very stable and the WiFi interface is even more stable than before. Furthermore, almost all the files that can be merged in the future with the ESP32 code are ready to be merged. You can see this when you search for `#ifdef MCU_ESP32` in the source code. And, all these files have already been tested with ESP8266 as well as ESP32. That is, their merge will become pretty easy.
The only open task that remain might be an implementation of newlibs `_lock_*` functions. On the other hand, all tests worked without any problems with newlib's dummy `_lock_*` functions. So I'm not sure whether it is really usefull to implement them. I have seen no RIOT platform that implements newlib's lock functions. Even more, implementing `_lock_*` function based on mutexes might lead to problems when locking newlib functions are called from interrupt context.
Anyway, from my point of view, the reimplementation is ready and it is a big step forward. I would be really grateful if you could find some time to review it berfore it becomes toooooo old and has to be rebased with a lot of effort again.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications