[riot-notifications] [RIOT-OS/RIOT] [gnrc_icmpv6_error] Fixed multicast detection (#12175)
notifications at github.com
Thu Sep 5 19:36:08 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Fixed gnrc_icmpv6_error.c multicast detection.
When sending a multicast udp packet, icmpv6_errors shouldn't be reported back to the sender.
Currently the src address is being checked for multicast, but it should be the dst address.
### Testing procedure
Send UDP packet to ff02::1 without having a receiver registered/the UDP server started in gnrc_networking on the other nodes. This will lead to errors being send back.
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* [gnrc_icmpv6_error] Fixed multicast detection
-- File Changes --
M sys/net/gnrc/network_layer/icmpv6/error/gnrc_icmpv6_error.c (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications