[riot-notifications] [RIOT-OS/RIOT] gnrc_netif_hdr: add setter for netif (#10661)

Marian Buschsieweke notifications at github.com
Sat Sep 7 13:06:07 CEST 2019


maribu commented on this pull request.

Please have a look at the inline comment. Otherwise, I will ACK this PR without further testing. (We decided to spend our testing time more on the release testing, as that will be a more efficient use of our testing time. And I think this PR is a textbook example of where insisting of testing every corner case only leads to frustration, while upstream would greatly benefit form this being merged.)

> @@ -38,19 +38,18 @@ static gnrc_netreg_entry_t server = GNRC_NETREG_ENTRY_INIT_PID(GNRC_NETREG_DEMUX
 static void send(char *addr_str, char *port_str, char *data, unsigned int num,
                  unsigned int delay)
 {
+    gnrc_netif_t *netif;
     int iface;
     uint16_t port;
     ipv6_addr_t addr;
 
     /* get interface, if available */
     iface = ipv6_addr_split_iface(addr_str);

This is the only remaining line in this function using `addr_str` (except for the printf). But it is not using `addr`. Without having read the API docs, it seems that the removed called to `ipv6_addr_from_str()` needs to be added somewhere in here to fill `addr` with meaningful content.

>      }
-    /* parse destination address */
-    if (ipv6_addr_from_str(&addr, addr_str) == NULL) {

This is the removed `ipv6_addr_from_str()` that referred to in the previous comment

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10661#pullrequestreview-285167227
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190907/7812afb6/attachment.htm>


More information about the notifications mailing list