[riot-notifications] [RIOT-OS/RIOT] sys/arduino: Added SPI interface (#12118)

Kees Bakker notifications at github.com
Sat Sep 7 22:58:02 CEST 2019


keestux commented on this pull request.



> +        default:
+        case SPI_MODE0:
+            mode = SPI_MODE_0;
+            break;
+        case SPI_MODE1:
+            mode = SPI_MODE_1;
+            break;
+        case SPI_MODE2:
+            mode = SPI_MODE_2;
+            break;
+        case SPI_MODE3:
+            mode = SPI_MODE_3;
+            break;
+    }
+
+    for (uint8_t i = 0; i < sizeof(steps)/sizeof(steps[0]); i++) {

We can (or should?) use ARRAY_SIZE, instead of the sizeof's

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12118#pullrequestreview-285187656
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190907/11fe6025/attachment.htm>


More information about the notifications mailing list