[riot-notifications] [RIOT-OS/RIOT] pkg/oonf_api: Use MRI script to combine archives. (#12155)

benpicco notifications at github.com
Mon Sep 9 17:31:58 CEST 2019


benpicco commented on this pull request.



>  .PHONY: all
 
 all:
 	"$(MAKE)" -C $(PKG_BUILDDIR)
-	"$(MAKE)" $(BINDIR)/$(MODULE).a
+	"$(MAKE)" $(COMBINED_ARCHIVE)
+
+PARTIAL_ARCHIVES = $(wildcard $(BINDIR)/oonf_*.a)
+
+$(COMBINED_ARCHIVE): $(BINDIR)/$(MODULE).mri $(PARTIAL_ARCHIVES)
+	ar -M < $<
+
+define ADDLIB_TEMPLATE
+addlib $1

I'm not that versed in `make` syntax, but this seems like it would do nothing.
Would this not just evaluate to
```
$(foreach a,$2,$(call addlib,$a))
``` 


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12155#pullrequestreview-285595431
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190909/00a758e6/attachment-0001.htm>


More information about the notifications mailing list