[riot-notifications] [RIOT-OS/RIOT] sys/ztimer: initial import (#11874)

Koen Zandberg notifications at github.com
Tue Sep 10 11:01:32 CEST 2019


bergzand requested changes on this pull request.

Minor issues I've found so far

> @@ -884,6 +884,26 @@ ifneq (,$(filter riotboot_hdr, $(USEMODULE)))
   USEMODULE += riotboot
 endif
 
+ifneq (,$(filter riotboot_slot, $(USEMODULE)))
+  USEMODULE += riotboot_hdr
+endif

Unrelated change?

> + *
+ * @{
+ *
+ * @file
+ * @brief       ztimer API
+ *
+ * @author      Kaspar Schleiser <kaspar at schleiser.de>
+ * @author      Joakim Nohlgård <joakim.nohlgard at eistec.se>
+ */
+
+#ifndef ZTIMER_H
+#define ZTIMER_H
+
+#include <stdint.h>
+
+#include "msg.h"

I think this also needs `kernel_types.h` to directly include `kernel_pid_t`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11874#pullrequestreview-285178787
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190910/d3832aaf/attachment-0001.htm>


More information about the notifications mailing list