[riot-notifications] [RIOT-OS/RIOT] gcoap: Add 'observable' option to resources (#11587)

Ken Bannister notifications at github.com
Tue Sep 10 11:36:47 CEST 2019

Thanks for following up. The review should go faster next time. ;-)

> 2. Add a locally defined constant to the coap_resource_t methods attribute. This attribute might be like COAP_OBSERVABLE or COAP_NOT_OBSERVABLE depending on what makes the most sense as a default. Then in _encode_link(), append the 'obs' link attribute based on the value in 'methods'.

The more I thought about this approach, it's definitely error prone for future system changes to the 'methods' attribute. It would be safer for an app to maybe extend `_link_params` into an array of a locally defined struct, where one of the attributes is its own 'methods' or 'flags' unsigned variable.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190910/01243699/attachment.htm>

More information about the notifications mailing list