[riot-notifications] [RIOT-OS/RIOT] make: add blob utility header (#11870)

Alexandre Abadie notifications at github.com
Wed Sep 11 11:31:40 CEST 2019


I was asked to have a look at this PR but I don't feel confident enough to give a valuable review on the Makefile changes. Especially because they touch `Makefile.base`. Maybe @cladmi or @jcarrano could be of more help here ?

I have more general comments btw:
>From the commit message linked above:
> For regular modules, adding files to BLOBS is sufficient to create the
corresponding headers.

So this means that this PR allows to embed blob defined in modules. The problem is that the test application doesn't show this. It's only applied to application blobs.

Another aspect is that the current implementation only generates a header from a text file and include this to the build. Conceptually, this is not really a blob.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11870#issuecomment-530301485
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190911/497ebe63/attachment.htm>


More information about the notifications mailing list