[riot-notifications] [RIOT-OS/RIOT] make: disable dwarf compression on CI builds (#12198)

Juan I Carrano notifications at github.com
Wed Sep 11 12:00:15 CEST 2019


jcarrano requested changes on this pull request.



> @@ -39,9 +39,10 @@ endif
 CFLAGS += -fno-common
 
 # Compress debug info. This saves approximately 50% of disk usage.
-# It has no effect if debugging information is not emitted, so it can be left
-# on unconditionally.
-OPTIONAL_CFLAGS += -gz
+# This makes ccache less effective, so disable for CI builds.
+ifneq (1, $(RIOT_CI_BUILD))

I second @miri64 , the test should not be for RIOT_CI_BUILD. The current meaning of RIOT_CI_BUILD is "turn off any non-determinism". I may want to build with both RIOT_CI_BUILD and debug. Also, the issue may not manifest itself if the path is not changed, which means even testing for CCACHE is too much.

This should be done in a way that is specific to murdock and nothing else.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12198#pullrequestreview-286681697
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190911/d19ed4c4/attachment.htm>


More information about the notifications mailing list