[riot-notifications] [RIOT-OS/RIOT] boards: Split off 128KiB version of bl*pill (#12169)
notifications at github.com
Wed Sep 11 13:25:52 CEST 2019
This indeed solves the issue I raised on the mailing list with the special `CPU_MODEL` handling for https://github.com/RIOT-OS/RIOT/pull/11477
I will do a PR that moves the `CPU/CPU_MODEL` after this one.
The refactoring with the `board_common.h` like this removed a lot of the previous duplication.
If I understand correctly, the `blackpill` is the same as the `bluepill` but with only a different `LED0` gpio. Is that correct?
If you want to make it a bit more clear and remove duplication of the value in the blackpill* boards, you could define both values in `board_common.h` and in the blackpill headers say `#define BLACKPILL_LED_MAPPING 1` or something. It would give only one definition and also document what are the default values.
But that is optimization and is not required in this PR.
Building `example/default` with all 4 boards in this PR give the same size as `bluepill` and `blackpill` in `master` as expected (considering the difference is only a gpio mapping).
The `128kib` versions can link `examples/gnrc_networking` when the `bluepill` could not.
The handling for `openocd` with duplication is currently the normal way of doing it in RIOT.
There could be a common file if we were using `--search` to give the config directory instead of an absolute path to the file as we do now, but it is not the case, so good to duplicate.
The documentation moved to `common/blxxxpill` now contains information for both boards and has been updated to remove the `FLASH_HACK`.
The documentation for using the `st-flash` has been removed, but it is not needed anymore as `openocd` is now used for flashing the `128KiB` directly.
However, I am not sure the common naming works, `bluepill` does not have the same number of letters as `blxxxpill` :p
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications