[riot-notifications] [RIOT-OS/RIOT] nanocoap: Move application functionality to nanocoap sock (#11488)

chrysn notifications at github.com
Wed Sep 11 18:22:31 CEST 2019


chrysn commented on this pull request.

As I understand this PR, RIOT's CoAP would be divided in nanocoap-message, nanocoap-socket and gcoap, where both the latter use the former to manipulate their messages. When the gcoap user needs to interact with nanocoap-message, they should not be presented with functions inapplicable to them. (Indeed that'd have saved me some time).

Looking at the built documentation, I don't think this is complete though; see inline comments, and:
* "Server path matching" is a prominent part in the nanocoap-message overview. As there is only one coap_resource_t method, it might be more suitable to describe there (after all, this is now only a tool method).

What I still can't fully judge is whether the separation is precise. Would anything go wrong if someone used, for example, coap-build_reply in a gcoap handler?

> @@ -18,7 +18,7 @@
  * provides high and low level interfaces to CoAP options, including Block.

The whole section could now use a name that indicates it's about the messages

> @@ -18,7 +18,7 @@
  * provides high and low level interfaces to CoAP options, including Block.
  *
  * nanocoap includes the core structs to store message information. It also
- * also provides support for sending and receiving messages, such as
+ * also provides functions to support sending and receiving messages, such as

```suggestion
 * also provides helpers for use before sending of after receiving messages, such as
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11488#pullrequestreview-286909284
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190911/a06f51cc/attachment.htm>


More information about the notifications mailing list