[riot-notifications] [RIOT-OS/RIOT] shell/sc_gnrc_ipv6_nib: extend for ABR (#10951)

benpicco notifications at github.com
Wed Sep 11 21:13:19 CEST 2019

benpicco commented on this pull request.

> @@ -45,7 +58,59 @@ int gnrc_ipv6_nib_abr_add(const ipv6_addr_t *addr);
  * @param[in] addr  The address of an authoritative border router.
 void gnrc_ipv6_nib_abr_del(const ipv6_addr_t *addr);

It's not, I just thought if the function can report an error anyway, might as well make use of it.

But if this is not idiomatic, I'm alwaysfor less overhead :)

I already wanted to suggest to just not advertise any function other than `show` for the !6BR case when they are doing nothing. Those debug strings tend to slowly eat up ROM over time.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190911/ec87b5d9/attachment.htm>

More information about the notifications mailing list