[riot-notifications] [RIOT-OS/RIOT] shell/sc_gnrc_ipv6_nib: extend for ABR (#10951)

Martine Lenders notifications at github.com
Wed Sep 11 21:59:45 CEST 2019


miri64 commented on this pull request.



> +            entry->version = abr->version;
+            entry->valid_until = abr->valid_until;
+            break;
+        }
+    }
+    mutex_unlock(&_nib_mutex);
+    *state = abr;
+    return (*state != NULL);
+}
+
+void gnrc_ipv6_nib_abr_print(gnrc_ipv6_nib_abr_t *abr)
+{
+    char addr_str[IPV6_ADDR_MAX_STR_LEN];
+    uint32_t now = _now_min();
+
+    printf("%s v%" PRIu32 " expires %" PRIu32 "min\n",

Matter of taste + the other print functions in `gnrc_ipv6_nib` use the same formatting.

See e.g.

https://github.com/RIOT-OS/RIOT/blob/729ba07e9acb4c84a411f3da1ba034a8cd125317/sys/net/gnrc/network_layer/ipv6/nib/nib_pl.c#L151-L156

If you want it to be changed, I gladly ACK a follow-up of your's that changes all of them :->

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/10951#discussion_r323431817
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190911/c7f1fcfa/attachment-0001.htm>


More information about the notifications mailing list