[riot-notifications] [RIOT-OS/RIOT] dist/tools/buildsystem_sanity_check: check no PORT exports (#12209)

Gaëtan Harter notifications at github.com
Thu Sep 12 14:44:31 CEST 2019


### Contribution description

Add sanity check for removed exports.

PORT is not exported anymore since https://github.com/RIOT-OS/RIOT/pull/10440 so prevent for re-appearing.

### Testing procedure

```
./dist/tools/buildsystem_sanity_check/check.sh
```
Returns no errors. (It is executed by the static tests too so would detect issues).

If adding this diff:

``` diff
diff --git a/Makefile b/Makefile
index 144cbd7e6..fe51b1bda 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,9 @@
 .all:
+# Nothing after: export PORT
+export PORT = space
+export PORT?= question_mark
+export PORT= equal
+export PORT:= colon
 
 .PHONY: all doc doc-man doc-latex docclean print-versions welcome

```

All the lines are detected

```
./dist/tools/buildsystem_sanity_check/check.sh 
Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
Variables must not be exported:
	Makefile:# Nothing after: export PORT
	Makefile:export PORT = space
	Makefile:export PORT?= question_mark
	Makefile:export PORT= equal
	Makefile:export PORT:= colon
```

### Issues/PRs references

Follow-up to https://github.com/RIOT-OS/RIOT/pull/10440 and part of https://github.com/RIOT-OS/RIOT/issues/10850
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/12209

-- Commit Summary --

  * dist/tools/buildsystem_sanity_check: check no PORT exports

-- File Changes --

    M dist/tools/buildsystem_sanity_check/check.sh (1)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/12209.patch
https://github.com/RIOT-OS/RIOT/pull/12209.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12209
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190912/6be1f3c2/attachment.htm>


More information about the notifications mailing list