[riot-notifications] [RIOT-OS/RIOT] dist/tools/buildsystem_sanity_check: check no PORT exports (#12209)
notifications at github.com
Thu Sep 12 14:44:31 CEST 2019
### Contribution description
Add sanity check for removed exports.
PORT is not exported anymore since https://github.com/RIOT-OS/RIOT/pull/10440 so prevent for re-appearing.
### Testing procedure
Returns no errors. (It is executed by the static tests too so would detect issues).
If adding this diff:
diff --git a/Makefile b/Makefile
index 144cbd7e6..fe51b1bda 100644
@@ -1,4 +1,9 @@
+# Nothing after: export PORT
+export PORT = space
+export PORT?= question_mark
+export PORT= equal
+export PORT:= colon
.PHONY: all doc doc-man doc-latex docclean print-versions welcome
All the lines are detected
Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
Variables must not be exported:
Makefile:# Nothing after: export PORT
Makefile:export PORT = space
Makefile:export PORT?= question_mark
Makefile:export PORT= equal
Makefile:export PORT:= colon
### Issues/PRs references
Follow-up to https://github.com/RIOT-OS/RIOT/pull/10440 and part of https://github.com/RIOT-OS/RIOT/issues/10850
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* dist/tools/buildsystem_sanity_check: check no PORT exports
-- File Changes --
M dist/tools/buildsystem_sanity_check/check.sh (1)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications