[riot-notifications] [RIOT-OS/RIOT] dist/tools/buildsystem_sanity_check: check no PORT exports (#12209)

Martine Lenders notifications at github.com
Thu Sep 12 15:10:33 CEST 2019


ACK. Tested by applying the following patch:

```
diff --git a/makefiles/tools/serial.inc.mk b/makefiles/tools/serial.inc.mk
index 215a5057e8..bad2d95f85 100644
--- a/makefiles/tools/serial.inc.mk
+++ b/makefiles/tools/serial.inc.mk
@@ -1,9 +1,9 @@
 # set default port depending on operating system
 OS := $(shell uname)
 ifeq ($(OS),Linux)
-  PORT ?= $(PORT_LINUX)
+  export PORT ?= $(PORT_LINUX)
 else ifeq ($(OS),Darwin)
-  PORT ?= $(PORT_DARWIN)
+  export PORT ?= $(PORT_DARWIN)
 endif
 ifeq ($(PORT),)
   $(info Warning: no PORT set!)
```

```
$ ./dist/tools/buildsystem_sanity_check/check.sh 
Invalid build system patterns found by ./dist/tools/buildsystem_sanity_check/check.sh:
Variables must not be exported:
	makefiles/tools/serial.inc.mk:  export PORT ?= $(PORT_LINUX)
	makefiles/tools/serial.inc.mk:  export PORT ?= $(PORT_DARWIN)
$ echo $?
1
```

When reverting the patch the script passes without any output and status code 0

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12209#issuecomment-530818208
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190912/bf0eb586/attachment.htm>


More information about the notifications mailing list