[riot-notifications] [RIOT-OS/RIOT] pkg/nanopb: add nanoPb protocol buffers library package (#11565)

benpicco notifications at github.com
Thu Sep 12 19:28:29 CEST 2019


benpicco commented on this pull request.



> @@ -52,14 +52,18 @@ ifeq ($(strip $(ASSMSRC))$(NO_AUTO_SRC),)
   ASSMSRC := $(wildcard *.S)
 endif
 
+# include makefile snippets that modify GENSRC here:
+include $(RIOTBASE)/pkg/nanopb/nanopb.inc.mk

```suggestion
# include makefile snippets for packages in $(USEPKG) that modify GENSRC:
-include $(USEPKG:%=$(RIOTPKG)/%/Makefile.gensrc)
```

This solves two issues:
 - packages don't have to modify `Makefile.base`
 - if the package is not used, the package Makefile is not included.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11565#pullrequestreview-287587632
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190912/5c9aae7c/attachment.htm>


More information about the notifications mailing list