[riot-notifications] ***UNCHECKED*** Re: [RIOT-OS/RIOT] make: docker: delegate bind mounts to the containers (#12218)

Gaëtan Harter notifications at github.com
Fri Sep 13 12:07:52 CEST 2019


With the option being repeated 4 times (out of the 5 usage of `-v`) in the file, putting it in common would be better. It is not really clean code to have hardwritten values in the middle :)

Adding a `docker_volume ?= -v '$1:$2$(DOCKER_MOUNT_OPTION)'` function used everywhere and documenting `DOCKER_VOLUME_OPTION ?= :delegated` would be cool.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12218#issuecomment-531180609
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190913/7e0e7077/attachment.htm>


More information about the notifications mailing list