[riot-notifications] [RIOT-OS/RIOT] cpu/stm32_common/periph/gpio: Pull-down on gpio_init_af (#12236)

Thomas Stilwell notifications at github.com
Mon Sep 16 00:46:07 CEST 2019


This change is necessary in one form or another.

Of course a better improvement would be to make pull resistors selectable in the board configuration, but currently stm32 doesn't allow that and in the mean time this is causing crashes.

Given the two choices of 1) pulling up by default (with this PR) versus 2) tristating by default (current master) I think it's clear that pulling up by default is the better option. Having a pull when you don't need one can cause a few uA of unwanted current consumption and not much else. Meanwhile not having a pull when you do need one can cause things like garbage characters in the uart rx buffer, nonworking uart rx, spurious uart rx interrupts, or even [mcu resets](/RIOT-OS/RIOT/issues/11460).

I think this is the overall best way to apply this fix until stm32 is updated to allow board-level configuration of pull resistors.

This PR should improve the situation over current master. ACK.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12236#issuecomment-531605990
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190915/be014adb/attachment.htm>


More information about the notifications mailing list