[riot-notifications] [RIOT-OS/RIOT] cpu/lpc2387: clean up the platform (#12229)

Marian Buschsieweke notifications at github.com
Mon Sep 16 09:42:33 CEST 2019


maribu commented on this pull request.



> @@ -110,4 +113,22 @@ void arm_reset(void)
     while(1) {}
 }
 
+/**
+ * @brief Initialize the CPU, set IRQ priorities, clocks
+ */
+void cpu_init(void)
+{
+    /* configure CPU clock */
+    cpu_init_clks();
+
+    /* set up GPIOs */
+    gpio_init_ports();
+

I think `board_init()` should be best called here, as it sets up UART0 needed for stdio.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12229#pullrequestreview-288455478
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190916/2bbbed4e/attachment.htm>


More information about the notifications mailing list