[riot-notifications] [RIOT-OS/RIOT] tools/docheck: fix for non-GNU OSes (#12240)
notifications at github.com
Mon Sep 16 11:15:29 CEST 2019
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This PR provides 2 fixes to run `./dist/tools/doccheck/check.sh` on non-GNU (Linux) OSes such as FreeBSD. First it allows to overwrite the `make` command through the environment, which is needed bc FreeBSD provides non-GNU make by default and thus RIOT must use `gmake` instead.
And second, there was also an encoding error in `generate-changelog.py` bc on FreeBSD if no encoding is set for `open` it defaults to `ascii` but RIOT uses `utf-8`.
### Testing procedure
Run `make static-test` or `./dist/tools/doccheck/check.sh` on your (favourite) OS and it should still work as usual.
### Issues/PRs references
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* tools/doccheck: allow config of `make` command
* doxygen: set encoding for open files in generate-changelog.py
-- File Changes --
M dist/tools/doccheck/check.sh (6)
M doc/doxygen/generate-changelog.py (6)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications