[riot-notifications] [RIOT-OS/RIOT] gnrc_tcp: Fix invocation of gnrc_pktbuf_add (#12079)

Martine Lenders notifications at github.com
Mon Sep 16 12:42:00 CEST 2019


miri64 approved this pull request.

An ACK by me. Indeed as the code currently stands it would risk writing garbage after `tcp_hdr` into the packet (and thus maybe exposing sensitive data to the network) or not to allocate enough space for the TCP header (if `offset * 4 < sizeof(tcp_hdr)`)



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12079#pullrequestreview-288540633
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190916/01c1041f/attachment.htm>


More information about the notifications mailing list