[riot-notifications] [RIOT-OS/RIOT] drivers/kw2xrf: Improved event callback policy (#12083)

Ilmu011 notifications at github.com
Mon Sep 16 13:39:26 CEST 2019


> Have you checked whether the NOACK event is being called as expected? I don't have the hardware to test with but my understanding is that SEQIRQ will be asserted at the end of the sequence no matter whether it ended with a received ACK or a timeout. That would mean that the check for TMR4IRQ is never reached.

I have checked, whether the NOACK event is being called as expected. It is. Which makes sense, since TMR4IRQ is always checked when SEQIRQ is NOT asserted. Did you miss the "`else`" at line 705 in kw2xrf.netdev.c or am I missing something?

NOACK is called correctly... but right now it doesn't do anything. From my understanding, the callback function is defined at [line 1408](https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/netif/gnrc_netif.c#L1408-L1446) in `sys/net/gnrc/netif/gnrc_netif.c`.

The only handled events are `NETDEV_EVENT_TX_MEDIUM_BUSY` and `NETDEV_EVENT_TX_COMPLETE`.

Everything else will be ignored and treated as an "unhandled event".

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12083#issuecomment-531741202
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190916/b0997059/attachment.htm>


More information about the notifications mailing list