[riot-notifications] [RIOT-OS/RIOT] periph/gpio: add gpio_set_cb() function (#12082)

Marian Buschsieweke notifications at github.com
Tue Sep 17 14:24:18 CEST 2019


> Guard with irq_disable/restore

+1

> or add a note that this should be done externally?

I strongly disagree. Keep in mind that people like me want to use the API. And this is how people like me are trying to drink water out of glass:

![me trying to drink](https://i.imgur.com/OH5AI6S.gif)

With this image in mind: Externally disabling interrupts is certainly to much to ask for ;-) (Also keep in mind that race conditions never trigger during development and testing. They wait until someone depends on it to show up.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12082#issuecomment-532196977
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190917/7e262892/attachment.htm>


More information about the notifications mailing list