[riot-notifications] [RIOT-OS/RIOT] makefiles: do not remove defines from CFLAGS (#12262)

Gaëtan Harter notifications at github.com
Tue Sep 17 15:47:42 CEST 2019


### Contribution description

Do not remove the '-D' and '-U' values from CFLAGS.
This prevents issues where a '-D' could contain a space.

Some values way be duplicated from the 'riotbuild.h' header and the
command line but with the same value so without conflict.

To not put too many things in the command line, the -DMODULE_NAME are
only put in CFLAGS_WITH_MACROS.

Also, as now, the deferred value of CFLAGS is used for 'riotbuild.h',
macros set after the inclusion of `Makefile.include` will be taken into
account.

### Testing procedure


**TODO**:

Test if it fixes

* https://github.com/RIOT-OS/RIOT/issues/5776
* https://github.com/RIOT-OS/RIOT/issues/9589
* https://github.com/RIOT-OS/RIOT/issues/12219


### Issues/PRs references

* https://github.com/RIOT-OS/RIOT/issues/5776
* https://github.com/RIOT-OS/RIOT/issues/9589
* https://github.com/RIOT-OS/RIOT/issues/12219

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/12262

-- Commit Summary --

  * makefiles: do not remove defines from CFLAGS

-- File Changes --

    M Makefile.include (8)
    M makefiles/modules.inc.mk (2)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/12262.patch
https://github.com/RIOT-OS/RIOT/pull/12262.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12262
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190917/364aabe5/attachment-0001.htm>


More information about the notifications mailing list