[riot-notifications] [RIOT-OS/RIOT] usbus: Add automated test (#12267)

Alexandre Abadie notifications at github.com
Tue Sep 17 22:55:40 CEST 2019


aabadie commented on this pull request.



> +USEMODULE += embunit
+USEMODULE += usbus
+FEATURES_PROVIDED += periph_usbdev
+
+# USB device vendor and product ID
+# pid.codes test VID/PID, not globally unique
+USB_VID ?= 1209
+USB_PID ?= 0001
+
+CFLAGS += -DUSB_CONFIG_VID=0x$(USB_VID) -DUSB_CONFIG_PID=0x$(USB_PID)
+
+include $(RIOTBASE)/Makefile.include
+
+.PHONY: usb_id_check
+usb_id_check:
+	@if [ $(USB_VID) = $(DEFAULT_VID) -o $(USB_PID) = $(DEFAULT_PID) ] ; then \

Maybe just replace [this line](https://github.com/RIOT-OS/RIOT/blob/master/.murdock#L1) with `#!/usr/bin/env bash` ?
I'm wondering why `/bin/sh` is still used instead of bash and what's wrong with bashing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12267#discussion_r325381542
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190917/1e3054b9/attachment.htm>


More information about the notifications mailing list