[riot-notifications] [RIOT-OS/RIOT] pyterm: Add device timeout (#12270)

Gaëtan Harter notifications at github.com
Wed Sep 18 12:02:14 CEST 2019


Question, with https://github.com/RIOT-OS/RIOT/pull/11085, does not the terminal disappear after the `make reset` ? Because that would cause many issues with the current state.
I want to get rid of `make reset` while `make term` is running as it is not always available and breaks on some boards. https://git.imp.fu-berlin.de/riot-appstore/riot-buildsystem-ci-server/blob/46ecfdb7e44b0e54832e0135bac46fe8638b6cf8/tools/makefiles.pre#L79-82

But it will need some migration to do an interactive synchronization (or any synchronization) with the test before dumping the output as for example: https://github.com/RIOT-OS/RIOT/commit/f193ffd604d8e1e1aa2b253c0036eea7e023d343

### Handling of the term not being ready

I would be somehow more for a `term-ready`, `term-available` target, to handle these issues of not being able to talk to the board before.
By default, it would do nothing, but on board that needs this 'tty' being not busy, would wait for it.
If the tty is ready, it would need to return "immediately" though, not sleep 5 seconds just in case.

Which would make that when you do `make term`, it waits until the device is there.

And in test, it could call `term-ready` before, wait until it returns, then start the test procedure with its `MAKE_TERM_STARTED_DELAY` thing.

This way, no issue with breaking the test due to the reconnect time not taken into account or giving a wrong failure reason:

https://github.com/RIOT-OS/RIOT/pull/10482#issuecomment-447866610

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12270#issuecomment-532615377
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190918/92fed148/attachment.htm>


More information about the notifications mailing list