[riot-notifications] [RIOT-OS/RIOT] sys/arduino: Added millis() (#12116)

Marian Buschsieweke notifications at github.com
Wed Sep 18 15:22:33 CEST 2019


> Notice that `millis()` will wrap around after 4294967 milliseconds.

Indeed. I think I should have better used `return xtimer_now_usec64() / US_PER_MS;` over `return xtimer_now_usec() / US_PER_MS;`. (On the AVR that would come with a significant cost, but wrapping around 3 orders of magnitude sooner than one would expect might lead to bugs. Especially as we try to mimic the behavior of the Arduino API.)

@keestux: Would you mind to fix this? Otherwise I'll put it on my todo and fix it after my vacation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12116#issuecomment-532681559
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190918/aa4f99f6/attachment.htm>


More information about the notifications mailing list