[riot-notifications] [RIOT-OS/RIOT] cpu/msp430_common: add flashpage_raw (#11960)

Francisco notifications at github.com
Thu Sep 19 11:31:51 CEST 2019


> ```
> void __attribute__((weak)) flashpage_read_raw(const void *buf, uint32_t addr, uint32_t size)
> {
>     memcpy(buf, (void*)addr, size);
> }
> ```

So extend the `flashpage_raw`? This is actually something I wanted to do and remove  the dependency of `flashpage_raw` with `flashpage`.

> But yes, it's probably better if those flashpage functions pass around addresses instead of pointers.

You would change `flashpage` api then? I was thinking of changing the api for `mtd` to receive `(void*)` as address so it cant get casted according to size. Whats the argument for one over the other? 

If we would got with `flashpage functions pass around addresses instead of pointers` then I would ave this as a second step and not in this PR.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11960#issuecomment-533049464
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190919/6bc2fc31/attachment.htm>


More information about the notifications mailing list