[riot-notifications] [RIOT-OS/RIOT] gnrc_ipv6: fix scan-build errors (#12274)

benpicco notifications at github.com
Thu Sep 19 17:35:37 CEST 2019

benpicco commented on this pull request.

> @@ -529,6 +529,9 @@ static void _handle_rtr_sol(gnrc_netif_t *netif, const ipv6_hdr_t *ipv6,
         _snd_rtr_advs(netif, &ipv6->src, false);
 #endif  /* GNRC_IPV6_NIB_CONF_6LR */
+    else {
+        (void)nce;  /* NCE is not used */
+    }

Oh, tricky!
I'd still think 

    (void) nce;

Would be nicer than the strange nopy-else, so a proper warning can still be triggered if the variable becomes unused in an unexpected way.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190919/2185e288/attachment.htm>

More information about the notifications mailing list