[riot-notifications] [RIOT-OS/RIOT] sys/arduino: use 64bit usec to compute millis() (#12275)

Kees Bakker notifications at github.com
Thu Sep 19 20:06:19 CEST 2019


### Contribution description

This is quick solution to avoid wrapping around after 4294967 milliseconds.
It uses xtimer_now_usec64 instead of xtimer_now_usec.

Notice that this is more expansive than the previous solution, especially
on AVR systems.

### Testing procedure

Use the new upcoming #12180 which adds support for using Arduino libraries. The test program is a simple loop with `TalkingLED`, flashing leds. Without the fix in this PR the test program will hang roughly after 4295 seconds. I realize that this is way too long for a normal test program. An alternative is to create a special test program which would bump the "now" value to, say 4290 seconds, wait 10 seconds and look at the `millis()`. But I don't think it is worth the effort.

### Issues/PRs references

See also #12180 and #12116 
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/12275

-- Commit Summary --

  * sys/arduino: use 64bit usec to compute millis()

-- File Changes --

    M sys/arduino/base.cpp (2)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/12275.patch
https://github.com/RIOT-OS/RIOT/pull/12275.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12275
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190919/40b76485/attachment.htm>


More information about the notifications mailing list