[riot-notifications] [RIOT-OS/RIOT] usbus: Add CDC-ACM (Serial console) function (#11085)

Alexandre Abadie notifications at github.com
Fri Sep 20 08:55:13 CEST 2019


aabadie commented on this pull request.



> + *
+ * @}
+ */
+
+#include <stdio.h>
+
+#include "isrpipe.h"
+
+#include "usb/usbus.h"
+#include "usb/usbus/cdc/acm.h"
+
+#if MODULE_VFS
+#include "vfs.h"
+#endif
+
+static usbus_cdcacm_device_t cdcacm;

> How about adding something like [...]

That might be cleanest. I tried something else using pseudomodules and conditional macros but I always end up having to `extern` something (a function in my second attempt).

Anyway, let's not change this in this PR. I can adapt this module like you suggest when I have something ready (I have already but I have to test it first).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11085#discussion_r326493473
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190919/95d8bc90/attachment.htm>


More information about the notifications mailing list