[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: Use awk/printf instead of echo -n when flashing esp32 (#12282)

Francisco notifications at github.com
Fri Sep 20 17:29:50 CEST 2019


fjmolinas commented on this pull request.

Thanks for the fix @LordTy! changes look good, Some nitpicking to get this in:

- Commits should look like this;

```
cpu/common/<CpuName>: changes for <CpuName>
cpu/<CpuName>: initial <CpuName> support
board/boardname: Initial <BoardName> support 
examples/* : blacklisting for <BoardName>
tests/* : blacklisting for <BoardName>
```

- In this case you could have both of your commits be squashed into one, if you need to put more details you can put them in the next line.

```
cpu/common/<CpuName>: changes for <CpuName>

- blah blah blah
- interesting details...
```

So maybe have your PR title as the commit, something like this: `cpu/esp32: use 'awk/printf' instead of 'echo'`.

You can squash directly once this is addressed.

Also could you please  post terminal output that this fixes the issue for you on mac OSX?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12282#pullrequestreview-291238204
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190920/1f8d894f/attachment.htm>


More information about the notifications mailing list