[riot-notifications] [RIOT-OS/RIOT] cpu/efm32/uart: fix handling of RX when no RX callback is configured (#12278)

Thomas Stilwell notifications at github.com
Sun Sep 22 00:09:16 CEST 2019


benemorius commented on this pull request.



> @@ -131,15 +129,16 @@ int uart_init(uart_t dev, uint32_t baudrate, uart_rx_cb_t rx_cb, void *arg)
 
         /* enable receive interrupt */
         LEUART_IntEnable(leuart, LEUART_IEN_RXDATAV);

What I did is leave the interrupt always enabled in the peripheral and put only an if-block around enabling the interrupt in the NVIC. I don't think there would be a functional change but I'm mostly indifferent about it and I'll add if-blocks if you disagree.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12278#discussion_r326876001
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190921/34fe2a31/attachment-0001.htm>


More information about the notifications mailing list