[riot-notifications] [RIOT-OS/RIOT] sys: Add Link Format module (#11189)

Ken Bannister notifications at github.com
Mon Sep 23 04:57:13 CEST 2019


kb2ma commented on this pull request.



> + * @brief   Decodes a string of link format. It decodes the first occurrence of
+ *          a link.
+ *
+ * @pre `(link != NULL) && (buf != NULL)`
+ *
+ * @param[out] link         link to populate. Must not be NULL.
+ * @param[in]  attrs        array of attrs to populate
+ * @param[in]  attrs_len    length of @p attrs
+ * @param[in]  buf          string to decode. Must not be NULL.
+ * @param[in]  maxlen       size of @p buf
+ *
+ * @return number of bytes parsed from @p buf in success
+ * @return CLIF_NOT_FOUND if the string is malformed
+ */
+ssize_t clif_decode_link(clif_t *link, clif_attr_t *attrs, unsigned attrs_len,
+                         char *buf, size_t maxlen);

`buf` should be a const char *. I believe there are a few other instances like this. Please review the rest of the API.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/11189#pullrequestreview-291549719
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190922/d31038d3/attachment.htm>


More information about the notifications mailing list