[riot-notifications] [RIOT-OS/RIOT] drivers/kw2xrf: Use TMR3 instead TMR4 to detect ACK timeout (#12287)

Ilmu011 notifications at github.com
Mon Sep 23 09:44:15 CEST 2019


_Originally posted by @PeterKietzmann in #12083_
> @Ilmu011 for the TMR3 vs TMR4 discussion, please keep that one separate in an own issue or even better in a fixing PR :-)

This driver currently uses TMR4 to detect ACK timeouts in TR operations. There is a dedicated timer for detecting timeouts in RX-operations and that is TMR3. I am working on #10364 right now and the kw41z driver uses TMR3 for this purpose, which seems to make more sense.

See [section 7.6.2](https://www.nxp.com/docs/en/reference-manual/MKW2xDxxxRM.pdf#page=171) of the Reference Manual "Using T3CMP to Abort an RX operation"
You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/12287

-- Commit Summary --

  * drivers/kw2xrf: use TMR3 instead TMR4 to detect ACK timeout
  * drivers/kw2xrf: Fixed IRQ handling order
  * drivers/kw2xrf: Reset interrupt bit for timer 3

-- File Changes --

    M drivers/kw2xrf/kw2xrf_netdev.c (41)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/12287.patch
https://github.com/RIOT-OS/RIOT/pull/12287.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/12287
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20190923/74304e69/attachment.htm>


More information about the notifications mailing list